Add test for string member of dictionaries #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjaeseok
approved these changes
Dec 31, 2017
romandev
changed the title
romandev
reviewed
Jan 1, 2018
template/dictionary_types.njk
Outdated
| @@ -17,6 +17,8 @@ | |||
| #ifndef GEN_DICTIONARY_{{name | snakecase | upper}}_H_ | |||
| #define GEN_DICTIONARY_{{name | snakecase | upper}}_H_ | |||
|
|
|||
| using namespace::std; | |||
There was a problem hiding this comment.
We just use std::string instead of this.
IDL string should be map with std::string.
There was a problem hiding this comment.
i fixed it to using std::string.
Signed-off-by: Hwanseung Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dictionary has string member, "std::" was missed in front of string
keyword. So, it makes build error.
ISSUE=#169