Check enum values before pass to native side. #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwanseung
force-pushed
the
auto_gen_enum
branch
from
f31cea0 to
86fb888
Compare
|
i rebased this patch. |
|
@hwanseung Your patch is broken in bots :( |
hwanseung
force-pushed
the
auto_gen_enum
branch
from
86fb888 to
d39cd40
Compare
|
@romandev i fixed it. |
romandev
reviewed
Oct 30, 2017
template/enum_types_header.njk
Outdated
| #include <set> | ||
| #include <string> | ||
|
|
||
| class EnumTypes { |
There was a problem hiding this comment.
IMHO, we don't need to generate this type.
We can just pass the string set into isValidEnum() directly.
There was a problem hiding this comment.
do you means to pass the string set into isVaildEnum() directly in interface_cpp.njk?
There was a problem hiding this comment.
i changed to pass to the string set as parameter.
generator/main.ts
Outdated
| env.renderString(enum_type_cpp_tmpl, {enums: idl_enum})); | ||
| } | ||
|
|
||
| // TODO(hwansueng) :: this function should be improved. |
There was a problem hiding this comment.
nit: // TODO(hwanseung): This function should be improved.
byeolbit
pushed a commit
to byeolbit/bacardi
that referenced
this pull request
Nov 16, 2017
Check enum values before pass to native side. ISSUE=lunchclass#80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check enum values before pass to native side.
ISSUE=#80