change self.obs.lunar_day (not defined) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slosar
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Yes, that is correct. Ideally this should be caught by a unit test, so if you have time, please write a unit test that will exercise this option. We should merge this after PR#47. @buddhasystem .
|
I'm looking over it now, seems safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor bug fix
Simulator.obs.lunar_dayis never definedMost likely refers to
Simulator.obs.time_rangeNoticed this when trying to run `python driver/run_sim.py config/realistic_example.yaml'
Not sure if this affects any other behavior elsewhere. Please review