Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pyproject.toml lines to make this a package #52

Merged
merged 1 commit into from
May 19, 2024
Merged

add pyproject.toml lines to make this a package #52

merged 1 commit into from
May 19, 2024

Conversation

xzackli
Copy link
Contributor

@xzackli xzackli commented May 18, 2024

This PR adds some lines to pyproject.toml so that one can install this as a package with

flit install

for i.e. local development.

@xzackli xzackli requested a review from buddhasystem May 18, 2024 19:39
@buddhasystem buddhasystem requested a review from slosar May 18, 2024 19:53
@buddhasystem
Copy link
Contributor

I defer it to Anze since that's an important step. It sounds great, of course.

Copy link
Contributor

@slosar slosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to complain here!

@slosar
Copy link
Contributor

slosar commented May 19, 2024

I don't understand why it doesn't run the github actions workflow. Even when I run it manually it just contines to say "Some checks haven't completed yet." Will override for now, but this needs fixing.

@slosar
Copy link
Contributor

slosar commented May 19, 2024

It used to work last time.

@slosar slosar merged commit 0c03f43 into main May 19, 2024
1 check passed
@slosar slosar deleted the package branch May 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants