Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder XML .ui files to correct tab orders for plugin config dialogs #1955

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

isf63
Copy link
Contributor

@isf63 isf63 commented Nov 13, 2023

Some fixes to lxqt-panel plugins config dialogs

Affected files:
plugin-mainmenu/lxqtmainmenuconfiguration.ui
plugin-networkmonitor/lxqtnetworkmonitorconfiguration.ui plugin-sensors/lxqtsensorsconfiguration.ui
plugin-spacer/spacerconfiguration.ui

Affected files:
plugin-mainmenu/lxqtmainmenuconfiguration.ui
plugin-networkmonitor/lxqtnetworkmonitorconfiguration.ui
plugin-sensors/lxqtsensorsconfiguration.ui
plugin-spacer/spacerconfiguration.ui
@isf63 isf63 changed the title Tab order fixes to panel plugin config dialogs Reorder XML .ui files to correct tab orders for plugin config dialogs Jan 5, 2024
@isf63 isf63 requested a review from tsujan January 19, 2025 18:19
@tsujan
Copy link
Member

tsujan commented Jan 21, 2025

Mostly good, but please also take care of the following blocks in lxqtsensorsconfiguration.ui:

       <item row="4" column="0">
        <widget class="QComboBox" name="detectedChipsCB">
         <property name="currentIndex">
          <number>-1</number>
         </property>
         <property name="frame">
          <bool>true</bool>
         </property>
        </widget>
       </item>
       <item row="3" column="0">
        <widget class="QLabel" name="detectedChipsL">
         <property name="text">
          <string>Detected chips:</string>
         </property>
        </widget>
       </item>

And also these blocks in spacerconfiguration.ui:

   <item row="0" column="2">
    <widget class="QSpinBox" name="sizeSB">
     <property name="minimum">
      <number>4</number>
     </property>
     <property name="maximum">
      <number>2048</number>
     </property>
     <property name="value">
      <number>8</number>
     </property>
    </widget>
   </item>
   <item row="0" column="1">
    <widget class="QRadioButton" name="sizeFixedRB">
     <property name="text">
      <string>fixed</string>
     </property>
    </widget>
   </item>

Copy link
Member

@tsujan tsujan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@tsujan tsujan merged commit 3438f2a into lxqt:master Jan 21, 2025
@isf63 isf63 deleted the tab_order branch January 24, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants