Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: No claim on wrap/unwrap/transfer #103

Open
wants to merge 1 commit into
base: feat/principal-based-accounts
Choose a base branch
from
Open

feat: No claim on wrap/unwrap/transfer #103

wants to merge 1 commit into from
+217 −281

Conversation

deluca-mike
Copy link
Collaborator

No description provided.

@deluca-mike deluca-mike added the enhancement New feature or request label Jan 13, 2025
@deluca-mike deluca-mike self-assigned this Jan 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

LCOV of commit b31c25c during Forge Coverage #538

Summary coverage rate:
  lines......: 98.4% (247 of 251 lines)
  functions..: 98.2% (56 of 57 functions)
  branches...: 88.0% (22 of 25 branches)

Files changed coverage rate:
                       |Lines       |Functions  |Branches    
  Filename             |Rate     Num|Rate    Num|Rate     Num
  ===========================================================
  src/WrappedMToken.sol|23.4%    222|41.2%    51|    -      0

@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from 76f82b0 to d447ba7 Compare January 13, 2025 22:06
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from b3ad627 to 390ad0d Compare January 13, 2025 22:08
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from d447ba7 to e261b7b Compare January 14, 2025 19:03
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from 390ad0d to ae1eea3 Compare January 14, 2025 19:04
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from e261b7b to b27e0af Compare January 14, 2025 19:19
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from ae1eea3 to f3f9f72 Compare January 14, 2025 19:20
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from b27e0af to 8c6a412 Compare January 14, 2025 19:56
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from f3f9f72 to d78f865 Compare January 14, 2025 19:56
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from 8c6a412 to eba643f Compare January 16, 2025 18:27
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from d78f865 to f0a619b Compare January 16, 2025 18:28
toninorair
toninorair approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@toninorair toninorair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great work

PierrickGT
PierrickGT approved these changes Jan 16, 2025
View reviewed changes
test/integration/MorphoBlue.t.sol Outdated Show resolved Hide resolved
test/integration/MorphoBlue.t.sol Outdated Show resolved Hide resolved
test/integration/Protocol.t.sol
@@ -290,20 +290,20 @@ contract ProtocolIntegrationTests is TestBase {
assertEq(_wrappedMToken.accruedYieldOf(_dave), 0);

// Alice transfers all her tokens and only keeps her accrued yield.
_transferWM(_alice, _carol, 100_000000);
_transferWM(_alice, _carol, 99_999999);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 100_000000 now that we always receive 1 wM for 1 M?

Copy link
Collaborator Author

@deluca-mike deluca-mike Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not built on top of the wrap/unwrap fix PR. For the time being, they are separate features that are not mutually exclusive.

@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from eba643f to 3d3bde5 Compare January 17, 2025 15:59
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from f0a619b to c1587b0 Compare January 17, 2025 16:00
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from 3d3bde5 to b452ee9 Compare January 17, 2025 19:29
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch 2 times, most recently from 9b2906e to 5b4d743 Compare January 17, 2025 19:32
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from b452ee9 to 0e76045 Compare January 17, 2025 19:39
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from 5b4d743 to 492962f Compare January 17, 2025 19:39
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from 0e76045 to 8f65b68 Compare January 17, 2025 19:46
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from 492962f to 108860e Compare January 17, 2025 19:47
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from 8f65b68 to 7813bef Compare January 20, 2025 17:15
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from 108860e to 7090d0d Compare January 20, 2025 17:15
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from 7813bef to 2a4be08 Compare January 21, 2025 18:57
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from 7090d0d to ca4872d Compare January 21, 2025 18:57
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from 2a4be08 to 04502d8 Compare January 21, 2025 19:02
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from ca4872d to f791a7a Compare January 21, 2025 19:02
@deluca-mike deluca-mike force-pushed the feat/principal-based-accounts branch from 04502d8 to b6e8c41 Compare January 21, 2025 20:45
@deluca-mike deluca-mike force-pushed the feat/no-claim-on-transfer branch from f791a7a to b31c25c Compare January 21, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierrickGT PierrickGT PierrickGT approved these changes

@toninorair toninorair toninorair approved these changes

@0xIryna 0xIryna Awaiting requested review from 0xIryna

@Oighty Oighty Awaiting requested review from Oighty

Assignees

@deluca-mike deluca-mike

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deluca-mike @toninorair @PierrickGT