feat: post-deploy v2 prep #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
deluca-mike
commented
Jan 13, 2025
deluca-mike
commented
- solc 0.8.26
- latest common
- latest forge-std
- registrar as constructor arg
- excess destination as constructor arg
- constants made public
- token name changed
- batch start and stop earning
- IsApprovedEarner and NotApprovedEarner errors have account as parameter
- Indexing Math no longer needed?
- Basic Migrator contract introduced
- version bump
- use more from common
- zero account checks
deluca-mike
added
documentation
LCOV of commit
|
deluca-mike
force-pushed
the
feat/v2-prep
branch
from
e635cb7 to
60b0d42
Compare
PierrickGT
approved these changes
Jan 14, 2025
deluca-mike
force-pushed
the
feat/v2-prep
branch
from
455c2f3 to
5d3aa3e
Compare
0xIryna
approved these changes
Jan 14, 2025
toninorair
reviewed
Jan 16, 2025
toninorair
reviewed
Jan 16, 2025
toninorair
approved these changes
Jan 16, 2025
deluca-mike
force-pushed
the
feat/v2-prep
branch
3 times, most recently
from
9946c9f to
ce4261b
Compare
deluca-mike
force-pushed
the
feat/git-fixes
branch
from
6b57c30 to
050d781
Compare
deluca-mike
force-pushed
the
feat/v2-prep
branch
3 times, most recently
from
d25d55a to
448d79c
Compare
PierrickGT
reviewed
Jan 18, 2025
deluca-mike
force-pushed
the
feat/v2-prep
branch
from
448d79c to
0c2e70a
Compare
- solc 0.8.26 - latest common - latest forge-std - registrar as constructor arg - excess destination as constructor arg - constants made public - token name changed - `IsApprovedEarner` and `NotApprovedEarner` errors have account as parameter - basic Migrator contract introduced - version bump - use more from common - more test coverage - fixed scripts to allow for generic deploy and mainnet upgrade
deluca-mike
force-pushed
the
feat/v2-prep
branch
from
0c2e70a to
af7448e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.