-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load user-defined cpd aliase from XCA (compounds_auto.csv) #1262
Comments
My conversations with Jenke about including ASAP IDs in the download makes this ticket relevant again |
In the legacy/v1 implementation, aliases could be defined in the The ASAP ID's are in SoakDB so maybe we don't need to place the onus for those on the curators, can they just be extracted from SoakDB. We still need to think about how the aliases are shown in the frontend (see #1322) |
@phraenquex says the simplest solution may be for XCA to put the compound aliases (crystal_name, zinc_id, asap_id) into a new CSV file in extra_files. This will mean that the ASAP ID's will be in the download. After XCA the file exists in extra_files and the curator can add/change the aliases before upload The f/e work is separate, see #1412. @tdudgeon to get the ASAP ID's from SoakDB (@Waztom to provide example) and create the csv in the extra_files output |
@tdudgeon was unable to find the ASAP ID's. @Waztom please help Tim with this. @tdudgeon are you able to proceed with generating the CSV using the existing zinc/compound IDs while you wait for the ASAP ID's from SoakDb? Can the XCA generated sites be included in the CSV too? @phraenquex please provide @tdudgeon with the required properties |
Columns to include:
XCA generates columns 1-4; Loader will append the remaining columns. |
@phraenquex SC vs. LC for conformation site, crystalform site, assembly, and crystalform - there's currently no separate short and long code for these. Do you mean the short name generated for a tag? |
I meant the short name, the thing that goes before the dash. Come to think of it, just put in a single column for each of those - it's anyway just for info. |
@tdudgeon has implemented the following:
@kaliif the columns 5 and onwards from Frank's spec are no longer needed in the loader (as they are covered by the metadata.csv) |
@kaliif please verify that any extra columns added to the summary csv will be loaded by the target loader, and also included in the metadata.csv generated for the download. |
@kaliif is still working on this |
@mwinokan what needs to happen on data load? The way it's implemented now is on download, the extra columns are added to the file. |
@kaliif yes that will be sufficient. |
@kaliif says this is in staging but testing has only been local so far. Likely one of Ryan's targets will be first to test these manual alias files, once they've been uploaded we should test the download as well. |
Spec has been updated above, and a spin-out ticket for the f/e and API changes #1540. @tdudgeon adds that we will need to support combi-soaks for the @tdudgeon says we could add a ligand_name column to the generated CSV:
The user can then duplicate this file (
|
@tdudgeon has added the ligand_name column to the compounds_auto.csv and all the data is in the metadata.yaml @tdudgeon says that the compounds_auto.csv is not used by the loader, but it serves a purpose in the final target download and to serve as a template for compounds_manual.csv @phraenquex clarifies that there is no explicit format specification for the new aliases |
@kaliif is starting to work on this ticket now |
@mwinokan I don't understand this point, I'm afraid. I don't know what comes from SoakDB or what needs to be updated. |
@tdudgeon has added the @kaliif Regarding the
So a user might provide (for a given dataset/lig name):
e.g. in this compounds_manual.csv example the
@tdudgeon says that the lookup can be done using the |
Dev done, needs testing, not merged to staging yet |
@mwinokan please test once the clusters are back |
@kaliif's latest backend has fixed the tarball issue (see comment in 1540). |
@kaliif says the b/e part is in staging |
@matej-vavrek is there a b/e difference between your stack and staging currently that affects this ticket? |
Need a mechanism to upload compound aliases. Probably a CSV, indexed by smiles string.
Need a way to see aliases in LHS. Probably tooltip.
Need a way to find by alias. Likely, search button should search through all aliases
Need a way to switch which alias is displayed in LHS. E.g. "switch alias" modal from top of Hit Navigator
The text was updated successfully, but these errors were encountered: