This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Replace strings with byte slices for filters #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: still need to account for utf8 rune size in the slicing inside some of the filters. |
xichen2020
reviewed
Mar 28, 2017
rules/rule.go
Outdated
| @@ -330,52 +346,35 @@ func (rs *ruleSet) rollupResults(id string) []RollupResult { | |||
| } | |||
|
|
|||
| type matchedValue struct { | |||
There was a problem hiding this comment.
If we are doing N^2 passes below, this struct is no longer needed.
| } | ||
| // toRollupResults encodes rollup target name and values into ids for each rollup target | ||
| func (rs *ruleSet) toRollupResults(id []byte, targets []RollupTarget) []RollupResult { | ||
| // NB(r): This is n^2 however this should be quite fast still as |
There was a problem hiding this comment.
Why are we replacing one-pass scan with n-pass scans? Is it to save the memory allocation for the map?
There was a problem hiding this comment.
Mainly because using bytes makes this need to use a map of hashed IDs which seems more expensive overall in terms of creation and computation than simply just n^2 on a small set of matched rules.
There was a problem hiding this comment.
I see, fair enough, if the number of rollup rules gets out of hand we can revisit
|
Opened issue #24 to tackle UTF8 in future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes all APIs that interact with metric IDs and tags from string arguments to byte slices. This helps us use a lower common denominator for components that don't need any string representation of IDs but still need filtering capabilities. We've seen in benchmarks this drastically reduces overhead in our more high throughput components.
cc @xichen2020 @martin-mao @kobolog @kobolog