Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default mounting path #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change default mounting path #22

wants to merge 1 commit into from

Conversation

ElDeveloper
Copy link
Member

See #20.

@ElDeveloper
Copy link
Member Author

@tessus and @jcrbloch (and really everyone else) let me know if this looks good to you guys.

@mischievous
Copy link

mischievous commented Jan 1, 2017

The version of fuse 3.5.x will create the mount points for you automagically. No need to create them in MacFusion if the user is running fuse 3.5.x. But the filesystems need to recognize this fact now too. I have a fix for the SSHFS. Could an option be added to have MacFusion create the directory or not? Or even better detect that the code is running on Sierra or later and then auto set the option to create the mount point or not.

@166MMX
Copy link
Contributor

166MMX commented Jan 2, 2017

@mischievous Oh that is great news :)
Such conditions could be implemented. Would you mind sharing your SSHFS fix with us? I know that we can get the osxfuse version number. Not sure if we also can get the version of sshfs but that should be neglectable.

@tessus
Copy link
Collaborator

tessus commented Jan 2, 2017

@166MMX please send me an email. There are a few sshfs / fuse issues I'd like to explain, but I couldn't find your email.

@mischievous
Copy link

@166MMX when you say share... You mean create a branch of the osxfuse/sshfs and check in my changes to it? I can do that.

@mischievous
Copy link

I think I did it. https://github.com/mischievous/sshfs

@ElDeveloper
Copy link
Member Author

But the filesystems need to recognize this fact now too. I have a fix for the SSHFS.

@tessus Would this need to make its way to upstream, or do you think we can just keep this fork as a submodule of the project and compile that? You are more familiar with the problems/internals of sshfs.

Such conditions could be implemented. Would you mind sharing your SSHFS fix with us?

@166MMX I agree, this doesn't sound too complicated, if I am understanding correctly, we would just need to change the MFServerFS setupMountPoint method to deal with this logic.

Could an option be added to have MacFusion create the directory or not? Or even better detect that the code is running on Sierra or later and then auto set the option to create the mount point or not.

Yes, I think this sounds like a great idea. This should be easy to do. The one thing this PR is fixing though is the fact that we no longer can write to /Volumes/ (to quote @mischievous - Bloody apple!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants