Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Sierra /usr/bin/security appends a junk line on the entitlement… #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madmunki
Copy link

@madmunki madmunki commented Sep 8, 2016

macOS Sierra /usr/bin/security appends a junk line on the entitlements xml/plist file that breaks signing. This fix removes the junk line.

@madmunki
Copy link
Author

madmunki commented Sep 8, 2016

Fixes issue: Signing failed #91

@Mr-Berna
Copy link

This fix merely address the symptom, ignoring the actual cause of the problem. In the -doEntitlementsFixing method an NSTask runs security as a subprocess. Something has changed with the security command, and it's producing an error message now.

security outputs this error message on standard error. In -doEntitlementsFixing, standard out and standard error are both sent to the same pipe, so this error message is mingled with the results. Standard error should be sent to its own pipe and handled separately. A simple workaround would be to just ignore this error, by removing the [generateEntitlementsTask setStandardError:pipe]; line.

The best fix would be to figure out what's wrong with the call to security, and fix that.

@guojunliu
Copy link

thanks,very good !!!

0xMarK added a commit to 0xMarK/iReSign that referenced this pull request Nov 17, 2016
maciekish#96 macOS Sierra /usr/bin/security appends a junk line on the entitlements xml/plist file that breaks signing. This fix removes the junk line.
maciekish#94 Libraries in Frameworks do not have Info.plist
maciekish#90 Resign all frameworks
maciekish#86 Solve Signer Identity Ambiguity
maciekish#80 Changed Distribution Files Encoding from ASCII to UTF-8
maciekish#72 Support MobileIron: Rename bundle id in CFBundleURLTypes
maciekish#44 Added Edit menu to allow Cut/Copy/Paste in Text Fields
@peterjenkins
Copy link
Contributor

Also fixes #99. The project is not functional without this commit.

@Boxer131
Copy link

Boxer131 commented Nov 5, 2021

😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants