Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] chore: unit tests #69

Closed
wants to merge 4 commits into from
Closed

[WIP] chore: unit tests #69

wants to merge 4 commits into from

Conversation

rishabhKalakoti
Copy link
Contributor

@rishabhKalakoti rishabhKalakoti commented Jan 12, 2020 •
edited
Loading

Description

Unit tests in progress:

addresses #15

  • showkeys
  • no config file
  • no keys present
  • multiple keys present
  • init
  • submit
  • fetchtask

@jamesgeorge007 jamesgeorge007 self-requested a review January 12, 2020 12:43
@jamesgeorge007 jamesgeorge007 added the enhancement New feature or request label Jan 12, 2020
jamesgeorge007
jamesgeorge007 requested changes Jan 12, 2020
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the unit test source files within a __tests__ directory.

@jamesgeorge007 jamesgeorge007 added this to the v1.3.0 milestone Jan 12, 2020
@rishabhKalakoti
Copy link
Contributor Author

rishabhKalakoti commented Jan 12, 2020 •
edited
Loading

How should I check the cases for no keys and multiple keys?
Snapshots?
I have not been able to do it with snaps yet. Getting a few errors.
Another option could be regex to verify console outputs.

jamesgeorge007
jamesgeorge007 requested changes Jan 18, 2020
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the unit test source files to src/commands/__tests__. That would make much sense.

@jamesgeorge007 jamesgeorge007 removed this from the v1.3.0 milestone Feb 29, 2020
@jamesgeorge007
Copy link
Member

closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishabhKalakoti @jamesgeorge007