Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional client cache #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add optional client cache #19

wants to merge 1 commit into from

Conversation

MichaelGrupp
Copy link
Member

Allows to get repeated lookup requests from memory instead of calling
the service again. Can be configured in the client constructor in C++ & Python.

@MichaelGrupp
Add optional client cache.
ebf0889 
Allows to get repeated lookup requests from memory instead of calling
the service again.
@MichaelGrupp
Copy link
Member Author

MichaelGrupp commented Feb 7, 2022 •
edited
Loading

As discussed with @carzum. I don't have good test cases, but to test you can add a dummy error log message here and it should only log once for repeated calls with same arguments within the cache time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brinij brinij Awaiting requested review from brinij

@domeinzer domeinzer Awaiting requested review from domeinzer

@tkachuk-magazino tkachuk-magazino Awaiting requested review from tkachuk-magazino

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaelGrupp