This repository has been archived by the owner on Nov 15, 2019. It is now read-only.
closes #1138: LRU bootstrap cache #1139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ustulation
suggested changes
Feb 28, 2019
povilasb
force-pushed
the
lru-bootstrap-cache
branch
from
78927c0 to
75d7b6e
Compare
ustulation
suggested changes
Mar 1, 2019
douglascaetano
force-pushed
the
lru-bootstrap-cache
branch
from
a96affa to
06c3d37
Compare
* Make it LRU rather than TLRU cache; * that means inactive peers for prolonged time won't be just removed from the cache; * even if peers are dead, keep them in the cache, if there is free room available; * when cache is full and we want to add new entry, simply remove the least recently used.
If we fail to connect to some peer, it does not mean we won't be able to connect to it in 5 minutes or so. Hence, don't just remove cached peers. Peers will be evicted from the bootstrap cache, if there's no more room for new directly accessible peers. Keep remove() function for future use which will definitely happen.
douglascaetano
force-pushed
the
lru-bootstrap-cache
branch
from
06c3d37 to
8ec9a30
Compare
When a packet is received from remote peer that was previously put in bootstrap cache, make sure we let the cache know that the peer is active.
douglascaetano
force-pushed
the
lru-bootstrap-cache
branch
from
8ec9a30 to
7dbeab1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evict peers from bootstrap cache only when the cache is full and we want to cache a new peer.