Initial autoupdate implementation #153
Conversation
|
Is it possible to attach the cd drive dynamically with Otherwise lgtm |
|
@oberien That's what I was planning to do initially. However, there's no straightforward way to tell if/when the device is going to be ready. Plus, implementing the required QMP commands is somewhat weird (see #131). Permanently attaching the GA ISO is definitely not perfect but not that big of a deal either. It's there, whatever, just ignore it. Hypervisors have traditionally addressed this by creating an optical drive at boot time and allowing you to insert/remove ISO images at runtime. This does not work here however as the corresponding qemu APIs are still unstable/experimental. |
|
You should create a new issue then just to keep it in mind. (Also don't forget to update the reference in #131 ). If it wasn't for "Needs more testing.", I'd approve this PR. |
| let latest = Version::parse(include_str!("../../../guest-agent/VfioService/VfioService/Resources/Version.txt")).unwrap(); | ||
| match Version::parse(&version) { | ||
| Ok(version) => { | ||
| if version < latest { |
windows-gaming/driver/src/qemu.rs
Outdated
| @@ -46,6 +46,9 @@ pub fn run(cfg: &Config, tmp: &Path, data: &Path, clientpipe_path: &Path, monito | |||
| debug!("Samba started"); | |||
| } | |||
|
|
|||
| let ga = data.join("windows-gaming-ga.iso"); | |||
There was a problem hiding this comment.
naming: gaIso or something like that to easier see what this is. ga can have multiple meanings
Needs more testing.
Fixes #126.