Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Butcher the wizard #157

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] Butcher the wizard #157

wants to merge 4 commits into from

Conversation

main--
Copy link
Owner

@main-- main-- commented Aug 17, 2017

🔉 Fresh meat!

cc @Ediacarium

@main-- main-- added this to the Beta release milestone Aug 17, 2017
@oberien
Copy link
Collaborator

oberien commented Aug 18, 2017

I miss the amazing usb picker .

Ediacarium
Ediacarium reviewed Aug 20, 2017
View reviewed changes
Copy link
Collaborator

@Ediacarium Ediacarium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love a good shoulder

windows-gaming/config/src/vfio.rs
}
*/

fn write_vfio_modconf<W: Write>(machine: &MachineConfig, mut w: W) -> Result<()> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we make it consistent with the USB write_udev_rules?

Like, either use the config or get a list of devices

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps

@main--
Dynamic config options WIP draft
63e90bb 
@Ediacarium This sucks, how about we don't do it?
oberien
oberien reviewed Sep 16, 2017
View reviewed changes
windows-gaming/config/src/lib.rs Outdated

OptString(Property<Option<String>>),

Container {
Copy link
Collaborator

@oberien oberien Sep 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be named Struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ediacarium Ediacarium Ediacarium left review comments

@oberien oberien oberien left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Beta release
Development

Successfully merging this pull request may close these issues.
3 participants
@main-- @oberien @Ediacarium