Fixed an issue causing error when defining column options

manticoresoftware · Jan 7, 2025 · 096676a · 096676a
1 parent e3e0841
commit 096676a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/Manticoresearch/Endpoints/Indices/Create.php b/src/Manticoresearch/Endpoints/Indices/Create.php
@@ -23,14 +23,23 @@ class Create extends EmulateBySql
 	 */
 	protected $index;
 
+	protected function buildOptionsExpr($options) {
+		$exprParts = [];
+		foreach ($options as $k => $v) {
+			$exprParts[] = is_string($k) ? "$k='$v'" : $v;
+		}
+
+		return ' ' . implode(' ', $exprParts);
+	}
+
 	public function setBody($params = null) {
 		if (isset($this->index)) {
 			$columns = [];
 			if (isset($params['columns'])) {
 				foreach ($params['columns'] as $name => $settings) {
 					$column = '`' . $name . '` ' . $settings['type'];
 					if (isset($settings['options']) && sizeof($settings['options']) > 0) {
-						$column .= ' ' . implode(' ', $settings['options']);
+						$column .= $this->buildOptionsExpr($settings['options']);
 					}
 					$columns[] = $column;
 				}
@@ -47,6 +56,7 @@ public function setBody($params = null) {
 					}
 				}
 			}
+
 			return parent::setBody(
 				['query' => 'CREATE TABLE '.
 				(isset($params['silent']) && $params['silent'] === true ? ' IF NOT EXISTS ' : '').

diff --git a/test/Manticoresearch/Endpoints/Indices/CreateTest.php b/test/Manticoresearch/Endpoints/Indices/CreateTest.php
@@ -26,7 +26,7 @@ public function testCreateTableWithOptions() {
 				'columns' => [
 					'title' => [
 						'type' => 'text',
-						'options' => ['indexed', 'stored'],
+						'options' => ['indexed', 'stored', 'engine' => 'columnar'],
 					],
 					'price' => [
 						'type' => 'float',