Declare known baseType(s) instead of subTypes #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the assemblies
Caching should now work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
KnownBaseTypeAttributeandKnownBaseTypeWithPropertyAttributeattributes, which are basically the inversion ofKnownSubTypeAttributeandKnownSubTypeWithPropertyAttribute.Basically, the problem we were facing is we've got base classes which reside in nuget packages/other projects.
Currently, you needed to 1) have access to those base classes to add all needed attributes and thus 2) your derived classes needed to exist in the same project as their base class.
With these changes, we can mark our base class as
[JsonConverter(typeof(JsonSubtypes), "SomePropertyName")].Then, any other project can create derived classes and mark them via
[JsonSubtypes.KnownBaseTypeWithProperty(typeof(SomeBaseClass), "SomePropertyValue")].It uses the same caching method as the GetAttributes function, so the added performance overhead would be minimal.
You'd only need to scan all assemblies once to find those attributes.