Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for merge #105

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Add script for merge #105

merged 3 commits into from
Dec 5, 2023

Conversation

kiwakami
Copy link
Contributor

Closed #104.
Add script for merging zarr files and returning zip files.

@kiwakami kiwakami added the feature New feature or request label Nov 30, 2023
@kiwakami kiwakami added this to the v0.3 milestone Nov 30, 2023
@kiwakami kiwakami self-assigned this Nov 30, 2023
Copy link
Member

@astropenguin astropenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! Could you please check the following codes?

for corr in (DATA / "correlator").glob("*")

It will extract all files in the correlator directory (both .zarr and .dist.zarr).

correlator.convert(corr, overwrite=True)

Do we still need this?

@kiwakami
Copy link
Contributor Author

kiwakami commented Dec 1, 2023

Thank you for your comment!

  • I thought I was using NAME_FMT_CORR to specify *dist.zarr, but I realized that the for statement loops in vain, so I fixed it.
  • I noticed that correlator.convert(corr, overwrite=True)is not necessary.

Copy link
Member

@astropenguin astropenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. One more thing I noticed is that the path of the power meter Zarr specifies not a concatenated one but a specific measurement? If it is OK, please let me know and I will approve your PR!

@kiwakami
Copy link
Contributor Author

kiwakami commented Dec 5, 2023

Thank you. Power meter zarr WP7.6_2022144230000.zarr includes all time data, so there is no problem.

@kiwakami kiwakami merged commit 6f884ba into main Dec 5, 2023
3 checks passed
@kiwakami kiwakami deleted the #104-Add-script-for-merge branch December 6, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add script for merging specified zarr files
2 participants