Feature: only add ARIA-LABEL if the element does not already has one

[liorchamla]

Hey folks, this is a wonderful project ! So first thing first, thanks to all contributors, the library is great. We are working a lot on a11y since a week, and the problem we have with Marker is that it always has the same aria-label derived from a default string Marker.Title. But in our use case, we want Markers to be self explainatory to our audience.

Our custom HTML element for the marker has a good aria-label but it is replaced automaticly when the Marker is added to the map (addTo() method).

So my proposition here is to say : If the element already has an aria-label attribute that makes sense in the userland context, let's not replace it with the default Marker.Title.

Edit

By the way, I just found that there was an issue related (sort of) to my PR : #355

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (0061f85) to head (9c8c62b).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5298   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         282      282           
  Lines       38908    38910    +2     
  Branches     6829     6829           
=======================================
+ Hits        35735    35737    +2     
  Misses       3046     3046           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[liorchamla]

By the way, I can't understand why spellcheck is failing in the CI while it works fine inside my CodeSpace :'(

If you have any advice on what is missing ?

[HarelM]

This is related to awesome-maplibre project spelling issue there, I'll see if I can fix this quickly.