fix(retries): add sleep between retries and improve error messages

Signed-off-by: mudler <[email protected]>

pkg/client/http.go

@@ -3,7 +3,6 @@ package client
 import (
 	"bytes"
 	"encoding/json"
-	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -26,6 +25,10 @@ func NewClient(baseURL string) *Client {
 	}
 }
 
+// TODO: When submitting a job return a Job result
+// JobResult represents a client to interact with the job server and get the result asyncronously
+// The job result should be capable of waiting of the result, decrypting it and unmarshalling to a struct which is passed by (expected JSON response from the jobs)
+
 // SubmitJob submits a new job to the server and returns the job UID.
 func (c *Client) SubmitJob(job types.Job) (string, error) {
 	jobJSON, err := json.Marshal(job)
@@ -118,14 +121,15 @@ func (c *Client) WaitForResult(jobID string, maxRetries int, delay time.Duration
 
 	for {
 		if retries >= maxRetries {
-			return "", errors.New("max retries reached")
+			return "", fmt.Errorf("max retries reached: %w", err)
 		}
 		retries++
 
 		result, err = c.GetJobResult(jobID)
 		if err == nil {
 			break
 		}
+		time.Sleep(1 * time.Second)
 	}
 
 	return

pkg/client/http_test.go

@@ -133,7 +133,7 @@ var _ = Describe("Client", func() {
 			server.Close() // simulate unavailability
 			result, err := c.WaitForResult("job1", 3, time.Millisecond*10)
 			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(Equal("max retries reached"))
+			Expect(err.Error()).To(ContainSubstring("max retries reached"))
 			Expect(result).To(BeEmpty())
 		})
 	})