Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jobs): add twitter-scraper #13

Merged
merged 10 commits into from
Dec 5, 2024
Merged

feat(jobs): add twitter-scraper #13

merged 10 commits into from
Dec 5, 2024

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Nov 26, 2024

"github.com/sirupsen/logrus"
)

type TweetResult struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is extracted/adapted from the masa-oracle implementation

return tweets, nil
}

// End of adapted code from masa-oracle (commit: bf277c646d44c49cc387bc5219c900e96b06dc02)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this file,adaptation ends here

@@ -0,0 +1,45 @@
package twitter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package was entirely copied as-is. no changes introduced

@mudler
Copy link
Contributor Author

mudler commented Nov 26, 2024

Adapted on masa-finance/masa-oracle#638

@mudler mudler force-pushed the feat/twitter-scraper branch from c0072a2 to a490356 Compare November 26, 2024 17:59
@mudler
Copy link
Contributor Author

mudler commented Nov 26, 2024

TODO: add twitter tests

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 13.47518% with 122 lines in your changes missing coverage. Please review.

Project coverage is 43.90%. Comparing base (8af6478) to head (102d635).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/jobs/twitter.go 0.00% 121 Missing ⚠️
internal/jobserver/worker.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #13       +/-   ##
===========================================
- Coverage   57.35%   43.90%   -13.45%     
===========================================
  Files           6        7        +1     
  Lines         340      476      +136     
===========================================
+ Hits          195      209       +14     
- Misses        124      245      +121     
- Partials       21       22        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudler mudler force-pushed the feat/twitter-scraper branch from edf48e5 to 446f675 Compare November 27, 2024 08:55
@mudler mudler self-assigned this Dec 2, 2024
@mudler mudler marked this pull request as ready for review December 5, 2024 17:36
@mudler mudler merged commit 72a24df into main Dec 5, 2024
2 of 4 checks passed
@mudler mudler deleted the feat/twitter-scraper branch December 5, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move scraper code to tee-worker repository
1 participant