Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Change tag primary key to name + map id #44

Merged
merged 3 commits into from
Jul 27, 2024
Merged

Conversation

Ho-s
Copy link
Collaborator

@Ho-s Ho-s commented Jul 25, 2024

PR Type

  • Bugfix
  • Feature
  • Docs
  • Refactoring (no functional changes, no api changes)

For what purpose

태그 아이콘의 테이블을 뺌으로써, 태그의 테이블 구조를 바꿨습니다.

Key changes

  1. tag primary key 변경 ( id 삭제 , name + mapid 로 변경)
  2. tag column 명 변경 content -> name
  3. API body 혹은 param변경
  • maps/{id}/tag/{tagId} -> maps/{id}/tag/{name}
  • place/{mapId}/kakao/{kakaoPlaceId}: tagIds -> tagNames

To reviewers

잘 부탁드려요 ^^

Screenshots

Pasted Graphic Pasted Graphic 1

Copy link
Collaborator

@chanwoonglee chanwoonglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

썄 고생했어~!

Comment on lines 91 to 93
const tags = await this.tagRepository.find({
id: { $in: registerPlaceDto.tagIds },
name: { $in: registerPlaceDto.tagNames },
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 이렇게 되면 사용자가 선택한 tag 중 default tag에 대한 건 어떻게 저장하지?!
지금 불러오는건 커스텀 태그만 있는 것 같은데!
(+ find에서 mapId도 넣어줘서 찾아야겠다)

@Ho-s Ho-s merged commit 594b171 into stage Jul 27, 2024
3 checks passed
@Ho-s Ho-s deleted the feat/change-id-to-name branch July 27, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants