Refactor: Add error case #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 닉네임이 설정되지 않은 유저일 때, 에러케이스 추가
sally0226
requested review from
Ho-s,
chanwoonglee and
saehun
and removed request for
Ho-s
Ho-s
reviewed
Aug 14, 2024
| if (getNodeEnv === NODE_ENVIRONMENT.development) { | ||
| return { | ||
| path: '/', | ||
| maxAge: 360000, |
There was a problem hiding this comment.
로컬에서 테스트할때만 6분으로 해놔쓰
sally0226
added a commit
that referenced
this pull request
Aug 14, 2024
This reverts commit 0c1460b.
sally0226
commented
Aug 14, 2024
| sameSite: 'none', | ||
| secure: true, | ||
| path: '/', | ||
| expires: new Date(new Date().getTime() + 1000 * 60 * 60 * 24 * 1 * 365), |
There was a problem hiding this comment.
@Ho-s 그 외 환경(stage, prod)에서는 길고긴 만료시간!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
For what purpose
Key changes
To reviewers
Screenshots