Feature/rnb #516
Merged
Feature/rnb #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sookhee
approved these changes
Jul 16, 2024
| package com.example.moremenu.model | ||
|
|
||
| interface MoreMenuSideEffect { | ||
| data class NavigateMenu(val menu: Menu) : MoreMenuSideEffect |
There was a problem hiding this comment.
@Sookhee 더보기 메뉴에서 매숑이 키우기, 설정, 당근 등등 다른 메뉴 갈때 사용하려궁
| init { | ||
| viewModelScope.launch { | ||
| metaRepository.getRnb().onSuccess { | ||
| _moreMenuState.value = MoreMenuState(menus = it.toMenu()) |
There was a problem hiding this comment.
onFail 일 때 안내 문구를 준다거나 기본 메뉴 목록을 띄우는 등으로 처리해주는걸 추가하는건 어때여?
There was a problem hiding this comment.
@Sookhee 오류가 발생했어요 스크린이 있는데, 그게 알림에만 해당하는줄 알았는데 RNB쪽인 걸 방금 확인했엉 ㅋㅋㅋ 위치 수정해놓을께
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내역
sample
figma link
:
화면
close #<issue_number> 🦕