Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

알림 확인 했음을 체크하는 API 호출 위치 수정 #520

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

Sookhee
Copy link
Member

@Sookhee Sookhee commented Aug 6, 2024

작업 내역

  • 알림 확인 했음을 체크하는 API 호출 위치 수정
    • 기존에는 화면을 나갈 때 API를 호출했지만 호출이 제대로 되지 않았어서 알림을 읽어 왔을 때 바로 API 호출하도록 순서 변경
    • API 호스팅하는 주소 변경된 것 반영(push-histories/check -> push-histories)
  • 오래된 알림 -> 지난 알림으로 String 변경

image

Sookhee added 2 commits August 6, 2024 23:30
- 기존에는 화면을 나갈 때 API를 호출했지만 호출이 제대로 되지 않았어서 알림을 읽어 왔을 때 바로 API 호출하도록 순서 변경
- API 호스팅하는 주소 변경된 것 반영(push-histories/check -> push-histoies)
@Sookhee Sookhee self-assigned this Aug 6, 2024
@Sookhee Sookhee requested a review from 014967 as a code owner August 6, 2024 14:34
@Sookhee
Copy link
Member Author

Sookhee commented Aug 6, 2024

근데 내가 지금 이미 알림을 다 읽어버려서 ... 나중에 서버 쪽에 부탁해서 잘되나 테스트 해봐야할듯

Copy link
Contributor

@014967 014967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔해!

@014967 014967 merged commit be73a40 into feature/home_renewal Aug 7, 2024
2 checks passed
@014967 014967 deleted the feature/push-histories branch August 7, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants