Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix massa-client read only call #4493

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Fix massa-client read only call #4493

merged 4 commits into from
Oct 27, 2023

Conversation

modship
Copy link
Member

@modship modship commented Oct 19, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship changed the title fix number of parameters Fix massa-client read only call Oct 19, 2023
@modship
Copy link
Member Author

modship commented Oct 19, 2023

At the moment, this not working correctly; there is a serialization error.
Error: check if your node is running: ErrorObject { code: ServerError(-32080), message: "Parse error: invalid type: sequence, expected a map at line 1 column 558", data: None }

@modship
Copy link
Member Author

modship commented Oct 23, 2023

problem with :

massa/massa-ledger-exports/src/ledger_changes.rs

Line 35 in 104d53b

#[serde(serialize_with = "as_array")]

@modship modship marked this pull request as ready for review October 23, 2023 15:21
@modship modship requested a review from aoudiamoncef October 24, 2023 09:56
aoudiamoncef
aoudiamoncef previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@aoudiamoncef aoudiamoncef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@modship
Copy link
Member Author

modship commented Oct 25, 2023

bors merge

bors bot added a commit that referenced this pull request Oct 25, 2023
@bors @modship @aoudiamoncef
Merge #4493
76ee188 
4493: Fix massa-client read only call r=modship a=modship

* [ ] document all added functions
* [ ] try in sandbox /simulation/labnet
  * [ ] if part of node-launch, checked using the `resync_check` flag
* [x] unit tests on the added/changed features
  * [x] make tests compile
  * [x] make tests pass 
* [ ] add logs allowing easy debugging in case the changes caused problems
* [ ] if the API has changed, update the API specification

Co-authored-by: modship <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@modship modship requested a review from Leo-Besancon October 27, 2023 10:02
@modship
Copy link
Member Author

modship commented Oct 27, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 27, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@modship modship merged commit 7847535 into main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@aoudiamoncef aoudiamoncef aoudiamoncef left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modship @aoudiamoncef @Leo-Besancon