Remove compatibility layer in tracing

[aoudiamoncef]

• document all added functions
• try in sandbox /simulation/labnet
  • if part of node-launch, checked using the resync_check flag
• unit tests on the added/changed features
  • make tests compile
  • make tests pass
• add logs allowing easy debugging in case the changes caused problems
• if the API has changed, update the API specification

closes #4478

[AurelienFT]

A question about this changes, is it still possible to filter the logs with RUST_LOG standard log variable in this PR ?

[aoudiamoncef]

I'll check this before merging

IMHO, we should work on an easy way to enable and disable dependencies logs inside Massa. I did this with @modship to debug an issue in jsonrpsee.

[aoudiamoncef]

@AurelienFT could you test the behavior on main branch without this changes ? I get a weird result, I would like to get a confirmation.

[AurelienFT]

@AurelienFT could you test the behavior on main branch without this changes ? I get a weird result, I would like to get a confirmation.

When launching the node, we override the default value that could be in the env variable with our config.toml but in case of the test for example I use this standard variable (

massa/massa-test-framework/src/lib.rs

Line 36 in 5f56515

tracing_subscriber::fmt::layer().with_filter(EnvFilter::from_default_env());

) and so in the test that use the new framework we can choose level of print we want when we run our tests using the rust standard way.

[aoudiamoncef]

@AurelienFT can you confirm that It's working as expected in main branch ? (launch in debug with sandbox)

It's cool to choose, if we could inject a list of logger to enable with an env variable, It'll be awesome

[AurelienFT]

I just answered you above. The behaviour on the node will work as we are not using the env variable but a config file. In the tests it's not the case. I just want to be sure that your changes doesn't prevents us to see the logs in the tests.

[aoudiamoncef]

@AurelienFT after testing on buildnet_wip branch, It works

[AurelienFT]

And on this branch it works also?

The base branch was changed.

[Leo-Besancon]

I confirm that RUST_LOG var env is taken into account both with tracing:: and tracing::log::

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9a4f384) 71.78% compared to head (dd92b06) 71.78%.

Files	Patch %	Lines
massa-protocol-worker/src/connectivity.rs	0.00%	2 Missing ⚠️
...rotocol-worker/src/handlers/peer_handler/tester.rs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##           test_27_6_wip    #4535   +/-   ##
==============================================
  Coverage          71.78%   71.78%           
==============================================
  Files                291      291           
  Lines              51642    51642           
==============================================
  Hits               37069    37069           
  Misses             14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.