Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust node APIs settings #4536

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Adjust node APIs settings #4536

merged 2 commits into from
Nov 20, 2023

Conversation

aoudiamoncef
Copy link
Contributor

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon changed the base branch from main to buildnet_wip November 15, 2023 07:03
@aoudiamoncef aoudiamoncef added api Issues related to the API breaking labels Nov 15, 2023
@damip
Copy link
Member

damip commented Nov 17, 2023

@aoudiamoncef can we remove the change on the listening port for now and keep the other changes ?

@aoudiamoncef aoudiamoncef requested a review from damip November 20, 2023 10:04
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (buildnet_wip@dee3957). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             buildnet_wip    #4536   +/-   ##
===============================================
  Coverage                ?   72.55%           
===============================================
  Files                   ?      288           
  Lines                   ?    50874           
  Branches                ?        0           
===============================================
  Hits                    ?    36910           
  Misses                  ?    13964           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damip damip merged commit bd89081 into buildnet_wip Nov 20, 2023
11 of 12 checks passed
damip added a commit that referenced this pull request Nov 20, 2023
* Buildnet WIP

* Test dir + base case test

* Mock Final State/Improve tests execution (#4512)

* Use a controller for final state to be able to mock it

* Fix all formatting issues.

* Use more mocks in execution tests

* Fix test nested call usage

* improve some tests execution

* Fix tests async message and compact the test of executed

* Fix more execution tests

* Fix more tests.

* Update more tests

* Finish fixing all executions tests.

* Improve naming

* add more comment

* Fix comment

* Minor addition to test_standalone_selection

* Add test_invalid_roll_distribution

* Minor test_invalid_roll_distribution change

* fix clippy

* Fix double cursor advance (#4531)

Co-authored-by: sydhds <[email protected]>

* Fix massa db change history handling (#4533)

* Initial fix and test

To check: if < or <= to allow changes

* fmt + clippy

* fix comments

* Remove debug prints

* Cache miss error rename + u8::MAX

* Added comments about Included and CacheMiss

* Comment + Add StreamingStep::Ongoing to test

* Fix previous tests

* Bump self_cell from 1.0.1 to 1.0.2 (#4538)

Bumps [self_cell](https://github.com/Voultapher/self_cell) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/Voultapher/self_cell/releases)
- [Commits](Voultapher/self_cell@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: self_cell
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add test code coverage + checksums (#4470)

* ci: add test code coverage

* ci: add checksums to artifacts

* fix: cargo clean

* fix: trigger ci

* ci: last chance

* ci: skip macOS ...

* ci: silver bullet cache

* ci: add codecov

* ci: clean coverage utility

* ci: reset to main version

* Keep only event count in ExecutionContextSnapshot

Signed-off-by: Jean-François <[email protected]>

* updates

* update packages

* make test_standalone_selection generic (#4539)

* Create universes for bootstrap (#4528)

* Use a controller for final state to be able to mock it

* Fix all formatting issues.

* Use more mocks in execution tests

* Fix test nested call usage

* improve some tests execution

* Fix tests async message and compact the test of executed

* Fix more execution tests

* Fix more tests.

* Update more tests

* Finish fixing all executions tests.

* Improve naming

* Create universes for bootstrap

* add more comment

* Add bootstrap whitelist test correctly

* Update to make a correct bootstrap flow

* Change big bootstrap test and cleanup some unused variables

* Version of bootstrap tests with mock well organized

* Update bootstrap check database

* fix all tests bootstrap

* Fix tests massa db

* Update better tests

* modify condition

* Fix readonly (#4543)

* fix readonly

* update proto dep

* Fix bootstrap deser (#4537)

* Add length_value check in deserializer

* Update the logic

TODO:
- Fix UT fails
- Remove debug logs
- Refactor the serde of KV in a separate parser

* fmt

* Fix ser

* Remove prints

* Add duplicate key test in deserializer

* Add faulty message tests

* Fix & prints

* Update to take serialized len into account for streamBatch fill

* Rename + add comments

* Use Enum for faulty case instead of int

* Fix clippy

* Adjust node APIs settings (#4536)

* refactor: adjust APIs settings

* refactor: revert bind public address

* Improve ReadOnly estimations (#4545)

* Fix read only call & execution estimations

* Update comment

* Set async pool size to 1000 and add async msg fixed costs (#4546)

Signed-off-by: Jean-François <[email protected]>

* Update genesis

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Jean-François <[email protected]>
Co-authored-by: Thomas Plisson <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: sydhds <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Moncef AOUDIA <[email protected]>
Co-authored-by: Jean-François <[email protected]>
Co-authored-by: Damir Vodenicarevic <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
@Leo-Besancon Leo-Besancon linked an issue Nov 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calibrate and adjust APIs arguments limits
2 participants