Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources section and donate in-app #4135

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Jan 16, 2025

Fixes #4058

Fixes #4057

Screenshots

Home page with no databases

image

Home page with databases

image

Responsive behavior

narrow extra narrow
image image

Top-right menu

image

Upgrade page

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the v0.2.0 (beta release) milestone Jan 16, 2025
@seancolsen seancolsen marked this pull request as ready for review January 17, 2025 00:51
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Jan 17, 2025
@seancolsen
Copy link
Contributor Author

@pavish please review code.

@ghislaineguerin please review style.

@kgodey please review copy and overall end result.

@ghislaineguerin
Copy link
Contributor

@seancolsen Any specific reason why you decided to use cards around each resource? I was triying to avoid having cards against cards when the databases are listed, it makes the UI too busy.
Also, under software updates, can we have a left aligned section with a title, text and button instead of the right aligned with text underneath the button?

@seancolsen
Copy link
Contributor Author

To others following along: @ghislaineguerin and I have scheduled a call tomorrow to further discuss styling.

@seancolsen
Copy link
Contributor Author

@ghislaineguerin and I had a quick pairing session and agreed on some changes which I pushed up as 792e530.

Here is the result:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to donate page from app Display "Documentation & Resources" UI in more places
4 participants