github-workflow - More dynamic creation fixes, fix wrong call

maths · Mar 6, 2024 · 3bcb495 · 3bcb495
1 parent 5d4b70d
commit 3bcb495
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/tests/external/import_question_test.php b/tests/external/import_question_test.php
@@ -102,7 +102,7 @@ public function upload_file(string $contentpath):void {
         $fileinfo = core_files_external::upload($contextid, $component, $filearea, $itemid, $filepath,
                 $filename, $filecontent, $contextlevel, $instanceid);
 
-        $fileinfo = \external_api::clean_returnvalue(core_files_external::upload_returns(), $fileinfo);
+        $fileinfo = core_files_external::clean_returnvalue(core_files_external::upload_returns(), $fileinfo);
 
         $this->fileinfo = $fileinfo;
         unset($this->fileinfo['url']);

diff --git a/tests/lib_test.php b/tests/lib_test.php
@@ -153,7 +153,6 @@ public function test_get_question_data() {
         $qcategory = $generator->create_question_category(
                             ['contextid' => \context_course::instance($course->id)->id]);
         $user = $this->getDataGenerator()->create_user();
-        $this->user = $user;
         $this->setUser($user);
         $q = $generator->create_question('shortanswer', null,
                             ['name' => 'This is the first version', 'category' => $qcategory->id]);

diff --git a/tests/tidy_trait_test.php b/tests/tidy_trait_test.php
@@ -46,6 +46,8 @@ class tidy_trait_test extends advanced_testcase {
     public cli_helper $clihelper;
     /** @var curl_request mocked curl_request */
     public curl_request $curl;
+    /** @var curl_request mocked curl_request for question list */
+    public curl_request $listcurl;
     /** @var export_repo mocked curl_request for doc upload */
     public export_repo $exportrepo;
     /** @var string root of virtual file system */