quiz-data - Catch empty argument

maths · Dec 10, 2024 · e61b047 · e61b047
1 parent ede7681
commit e61b047
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/classes/create_repo.php b/classes/create_repo.php
@@ -140,7 +140,7 @@ public function __construct(cli_helper $clihelper, array $moodleinstances) {
         } else {
             $this->directory = $arguments['rootdirectory'];
         }
-        if ($arguments['nonquizmanifestpath']) {
+        if (!empty($arguments['nonquizmanifestpath'])) {
             $this->nonquizmanifestpath = ($arguments['rootdirectory']) ?
                     $arguments['rootdirectory'] . '/' . $arguments['nonquizmanifestpath'] : $arguments['nonquizmanifestpath'];
         } else {

diff --git a/classes/export_quiz.php b/classes/export_quiz.php
@@ -121,7 +121,7 @@ public function __construct(cli_helper $clihelper, array $moodleinstances) {
             $this->call_exit();
         }
         $instanceid = $this->quizmanifestcontents->context->instanceid;
-        if ($arguments['nonquizmanifestpath']) {
+        if (!empty($arguments['nonquizmanifestpath'])) {
             $this->nonquizmanifestpath = ($arguments['nonquizmanifestpath']) ?
                     $rootdirectory . $arguments['nonquizmanifestpath'] : null;
             $this->nonquizmanifestcontents = json_decode(file_get_contents($this->nonquizmanifestpath));

diff --git a/classes/export_repo.php b/classes/export_repo.php
@@ -131,7 +131,7 @@ public function __construct(cli_helper $clihelper, array $moodleinstances) {
         } else {
             $this->manifestpath = null;
         }
-        if ($arguments['nonquizmanifestpath']) {
+        if (!empty($arguments['nonquizmanifestpath'])) {
             $this->nonquizmanifestpath = ($arguments['rootdirectory']) ?
                         $arguments['rootdirectory'] . '/' . $arguments['nonquizmanifestpath'] : $arguments['nonquizmanifestpath'];
         } else {

diff --git a/classes/import_quiz.php b/classes/import_quiz.php
@@ -317,7 +317,7 @@ public function import_all($clihelper, $scriptdirectory): void {
         } else {
             $directory = $arguments['rootdirectory'];
         }
-        if ($arguments['nonquizmanifestpath']) {
+        if (!empty($arguments['nonquizmanifestpath'])) {
             $this->nonquizmanifestpath = ($arguments['rootdirectory']) ?
                     $arguments['rootdirectory'] . '/' . $arguments['nonquizmanifestpath'] : $arguments['nonquizmanifestpath'];
         } else {