quiz-data - Code check

classes/create_repo.php

@@ -316,4 +316,4 @@ public function call_repo_creation(string $rootdirectory, string $moodleinstance
                 $rootdirectory .  '" -i "' . $moodleinstance .
                 '" -l "module" -n ' . $instanceid . ' -t ' . $token . $ignorecat);
     }
-}
+}

classes/export_repo.php

@@ -103,7 +103,7 @@ class export_repo {
      * Set in config. Adds commit hash to manifest.
      * @var bool
      */
-   public bool $usegit;
+    public bool $usegit;
 
     /**
      * Constructor

classes/export_trait.php

@@ -214,6 +214,12 @@ public function export_to_repo_main_process(object $moodlequestionlist): void {
         }
     }
 
+    /**
+     * Export quiz structure
+     * @param mixed $clihelper
+     * @param mixed $scriptdirectory
+     * @return void
+     */
     public function export_quiz_structure($clihelper, $scriptdirectory) {
         $arguments = $clihelper->get_arguments();
         $moodleinstance = $arguments['moodleinstance'];

classes/import_quiz.php

@@ -285,6 +285,13 @@ public function process(): void {
         $this->import_quiz_data();
     }
 
+    /**
+     * Import quiz including structure.
+     * Creates quiz, imports questions, updates structure.
+     * @param mixed $clihelper
+     * @param mixed $scriptdirectory
+     * @return void
+     */
     public function import_all($clihelper, $scriptdirectory): void {
         if ($this->quizmanifestcontents) {
             echo "\nA question manifest already exists for this quiz in this Moodle instance.\n";
@@ -315,7 +322,7 @@ public function import_all($clihelper, $scriptdirectory): void {
         echo $output;
     }
 
-        /**
+    /**
      * Separate out exec call for mocking.
      *
      * @param string $rootdirectory

cli/importwholecoursetomoodle.php

@@ -96,7 +96,7 @@
         'default' => null,
         'variable' => 'modulename',
         'valuerequired' => true,
-        'hidden' => true
+        'hidden' => true,
     ],
     [
         'longopt' => 'coursecategory',

tests/create_repo_test.php

@@ -95,7 +95,7 @@ public function setUp(): void {
             'execute',
         ])->setConstructorArgs(['xxxx'])->getMock();;
         $this->createrepo = $this->getMockBuilder(\qbank_gitsync\create_repo::class)->onlyMethods([
-            'get_curl_request', 'call_repo_creation', 'call_export_quiz'
+            'get_curl_request', 'call_repo_creation', 'call_export_quiz',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
         $this->createrepo->curlrequest = $this->curl;
         $this->createrepo->listcurlrequest = $this->listcurl;

tests/export_repo_test.php

@@ -115,7 +115,7 @@ public function setUp(): void {
             'execute',
         ])->setConstructorArgs(['xxxx'])->getMock();
         $this->exportrepo = $this->getMockBuilder(\qbank_gitsync\export_repo::class)->onlyMethods([
-            'get_curl_request', 'call_exit', 'call_repo_creation', 'call_export_quiz', 'call_export_repo'
+            'get_curl_request', 'call_exit', 'call_repo_creation', 'call_export_quiz', 'call_export_repo',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
         $this->exportrepo->curlrequest = $this->curl;
         $this->exportrepo->listcurlrequest = $this->listcurl;
@@ -445,7 +445,7 @@ public function test_full_course_not_in_manifest(): void {
               "quizzes": [{"instanceid":"1", "name":"Quiz 1"}, {"instanceid":"2", "name":"Quiz 2"}]}')
         );
         $this->exportrepo = $this->getMockBuilder(\qbank_gitsync\export_repo::class)->onlyMethods([
-            'get_curl_request', 'call_exit', 'call_repo_creation', 'call_export_quiz', 'call_export_repo'
+            'get_curl_request', 'call_exit', 'call_repo_creation', 'call_export_quiz', 'call_export_repo',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
 
         $this->exportrepo->curlrequest = $this->curl;
@@ -488,7 +488,7 @@ public function test_full_course_in_manifest_no_directories(): void {
               "quizzes": [{"instanceid":"1", "name":"Quiz 1"}, {"instanceid":"2", "name":"Quiz 2"}]}')
         );
         $this->exportrepo = $this->getMockBuilder(\qbank_gitsync\export_repo::class)->onlyMethods([
-            'get_curl_request', 'call_exit', 'call_repo_creation', 'call_export_quiz', 'call_export_repo'
+            'get_curl_request', 'call_exit', 'call_repo_creation', 'call_export_quiz', 'call_export_repo',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
 
         $this->exportrepo->curlrequest = $this->curl;
@@ -535,7 +535,7 @@ public function test_full_course_in_manifest_existing_directories(): void {
               "quizzes": [{"instanceid":"1", "name":"Quiz 1"}]}')
         );
         $this->exportrepo = $this->getMockBuilder(\qbank_gitsync\export_repo::class)->onlyMethods([
-            'get_curl_request', 'call_exit', 'call_repo_creation', 'call_export_quiz', 'call_export_repo'
+            'get_curl_request', 'call_exit', 'call_repo_creation', 'call_export_quiz', 'call_export_repo',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
 
         $this->exportrepo->curlrequest = $this->curl;

tests/import_repo_test.php

@@ -1454,7 +1454,7 @@ public function test_full_course(): void {
                                 ]}')
         );
         $this->importrepo = $this->getMockBuilder(\qbank_gitsync\import_repo::class)->onlyMethods([
-            'get_curl_request', 'call_exit', 'call_import_repo', 'call_import_quiz_data'
+            'get_curl_request', 'call_exit', 'call_import_repo', 'call_import_quiz_data',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
 
         $this->importrepo->update_quizzes($this->clihelper, $this->rootpath . '/testrepoparent');
@@ -1488,7 +1488,7 @@ public function test_full_course_quiz_create_fail(): void {
                             "questions": [], "quizzes": [{"instanceid":"1", "name":"Quiz Wrong"}]}')
         );
         $this->importrepo = $this->getMockBuilder(\qbank_gitsync\import_repo::class)->onlyMethods([
-            'get_curl_request', 'call_exit', 'call_import_repo', 'call_import_quiz_data'
+            'get_curl_request', 'call_exit', 'call_import_repo', 'call_import_quiz_data',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
 
         $this->importrepo->update_quizzes($this->clihelper, $this->rootpath . '/testrepoparent');
@@ -1520,7 +1520,7 @@ public function test_full_course_quiz_already_imported(): void {
                             "questions": [], "quizzes": [{"instanceid":"1", "name":"Quiz 1"}]}')
         );
         $this->importrepo = $this->getMockBuilder(\qbank_gitsync\import_repo::class)->onlyMethods([
-            'get_curl_request', 'call_exit', 'call_import_repo', 'call_import_quiz_data'
+            'get_curl_request', 'call_exit', 'call_import_repo', 'call_import_quiz_data',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
         copy($this->rootpath . '/testrepo_quiz_quiz-1/fakeexportquiz_module_course-1_quiz-1_question_manifest.json',
         $this->rootpath . '/testrepo_quiz_quiz-1/fakeimport_module_course-1_quiz-1_question_manifest.json');
@@ -1557,7 +1557,7 @@ public function test_full_course_quiz_in_moodle(): void {
                                 {"instanceid":"2", "name":"Quiz 2"}]}')
         );
         $this->importrepo = $this->getMockBuilder(\qbank_gitsync\import_repo::class)->onlyMethods([
-            'get_curl_request', 'call_exit', 'call_import_repo', 'call_import_quiz_data'
+            'get_curl_request', 'call_exit', 'call_import_repo', 'call_import_quiz_data',
         ])->setConstructorArgs([$this->clihelper, $this->moodleinstances])->getMock();
         copy($this->rootpath . '/testrepo_quiz_quiz-1/fakeexportquiz_module_course-1_quiz-1_question_manifest.json',
         $this->rootpath . '/testrepo_quiz_quiz-1/fakeimport_module_course-1_quiz-1_question_manifest.json');