Deferred feedback: Add CSS to hide check button #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will reduce the flickering of the check button as the page loads.
|
Hi @sangwinc, I just wanted to follow up to see if you’ve had a chance to review this. Please let me know if I can provide any further details. Thanks so much! I have created a pull request to apply similar fix to moodle-qbehaviour_dfexplicitvaildate Best regards, |
|
I'm really very sorry I missed this @AnupamaSarjoshi! Thanks very much for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
Though we hide the check button using javascript in stack, there is some flickering of the check button that happens when the page loads. Hence adding CSS styling to reduce that flicker. Could you please review the fix?
Adding this to both qbehaviour_dfexplicitvaildate and qbehaviour_dfcbmexplicitvaildate.
Thanks,
Anupama