Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

big update. please check twice. #48

Merged
merged 7 commits into from
Aug 12, 2015
Merged

big update. please check twice. #48

merged 7 commits into from
Aug 12, 2015

Conversation

drauggres
Copy link
Contributor

fix #3
fix #15
fix #32
fix #46

Also, looks like #33 fixed too.

drauggres added 6 commits July 8, 2015 13:36
Revert "Fix 'Invalid array length' error"

This reverts commit 5110ca0.

Revert "Fix Invalid array length in Node v0.10.31"

This reverts commit 61cf28f.

Revert "fixed regression with allowed stack size limit js"

This reverts commit 6b04755.

Revert "formatting error created in wrapper and using its cached_trace"

This reverts commit 98f2044.
Since 14 Jan 2013, recursive call of Error.prepareStackTrace prohibited in v8
v8/v8@eadcc1c10cb0
@drauggres
Copy link
Contributor Author

@drauggres drauggres mentioned this pull request Aug 12, 2015
mattinsler added a commit that referenced this pull request Aug 12, 2015
big update. please check twice.
@mattinsler mattinsler merged commit d5d54f1 into mattinsler:master Aug 12, 2015
@mattinsler
Copy link
Owner

Published as version 0.2.8. Thanks so much for all the fixes!!!

@yinrong
Copy link

yinrong commented Nov 13, 2015

Hi, @mattinsler
With [email protected] there is still a problem!

url='xxx'
//require('longjohn')
require('request')
.get(url)
.pipe(require('zlib').createGunzip())
.pipe(require('fs').createWriteStream('t0.gz'))

uncomment "longjohn" will lead to the following error:

node_modules/longjohn/dist/longjohn.js:194
        throw e;
        ^

Error: socket hang up
    at onHangUp (_tls_wrap.js:1076:19)
    at g (events.js:260:16)
    at emitNone (events.js:72:20)
    at TLSSocket.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:905:12)
    at doNTCallback2 (node.js:450:9)
    at process._tickCallback (node.js:364:17)
---------------------------------------------
    at Readable.on (_stream_readable.js:665:33)
    at tickOnSocket (_http_client.js:486:10)
    at onSocketNT (_http_client.js:502:5)
    at doNTCallback2 (node.js:450:9)
    at process._tickCallback (node.js:364:17)
---------------------------------------------
    at ClientRequest.onSocket (_http_client.js:494:11)
    at Agent.addRequest (_http_agent.js:143:9)
    at new ClientRequest (_http_client.js:139:16)
    at exports.request (http.js:31:10)
    at exports.request (https.js:173:15)
...
---------------------------------------------
...
    at Module._compile (module.js:425:26)
    at Module._extensions..js (module.js:432:10)
    at Module.load (module.js:356:32)
    at Module._load (module.js:311:12)

the header of the url I'm getting is:

HTTP/1.1 200 OK
Content-Disposition: attachment; filename=keyword-20151113-165926-b6851a54e9f74fe1da0869140820af82.gz
Content-Type: application/octet-streamn
Date: Fri, 13 Nov 2015 09:30:19 GMT
Server: Apache
Last-Modified: Fri, 13 Nov 2015 09:00:24 GMT
ETag: "8000000063891557-37e319-524684a38fa00"
Accept-Ranges: bytes
Content-Type: application/x-gzip
Content-Length: 3662617

@drauggres
Copy link
Contributor Author

Take a look at #52 and #53, @yinrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants