CSVFile: Discuss thread safety, misc improvements #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauricioaniche
approved these changes
Oct 14, 2017
| } | ||
| } | ||
|
|
||
|
|
||
| /* Additional weird constructors. */ |
There was a problem hiding this comment.
these constructors are here to maintain compatibility of very old versions of repodriller. We may mark them as deprecated in the future.
There was a problem hiding this comment.
Given that old versions are available on Maven, is there a reason to keep deprecated methods around? I think we should mark them deprecated now and remove them entirely later.
|
|
||
| ps.flush(); /* TODO This has performance implications. */ |
There was a problem hiding this comment.
I think this dates back when repodriller crashed when an exception happens. Now that repodriller never crashes (awesome!! kk), we may leave it to the stream to decide when to flush. What do you think?
This was referenced Oct 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #70 and #64.