Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{{WebExtExamples}} is moved before {{Compat}} #29188

Merged
merged 2 commits into from
Sep 18, 2023
Merged

{{WebExtExamples}} is moved before {{Compat}} #29188

merged 2 commits into from
Sep 18, 2023

Conversation

sesamemaki
Copy link
Contributor

@sesamemaki sesamemaki commented Sep 18, 2023 •
edited by hamishwillee
Loading

Part of fixing #22631

@sesamemaki sesamemaki requested a review from a team as a code owner September 18, 2023 17:00
@sesamemaki sesamemaki requested review from willdurand and removed request for a team September 18, 2023 17:01
@github-actions github-actions bot added the Content:WebExt WebExtensions docs label Sep 18, 2023
@sesamemaki
Copy link
Contributor Author

If the change is appropriate, I would like to review the documents mentioned here rg -i '\{\{(WebExtExamples|Compat)' -p --color=never and make the relevant change. I'm waiting for your feedback.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-09-18 22:42:59)

@hamishwillee
Copy link
Collaborator

hamishwillee commented Sep 18, 2023 •
edited
Loading

Thank you very much. This is correct according to #22631 (comment)

I'd add a note to that issue just letting @rebloor know you are working on it.

@hamishwillee hamishwillee merged commit 1189443 into mdn:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@willdurand willdurand Awaiting requested review from willdurand willdurand is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

Assignees
No one assigned
Labels
Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesamemaki @hamishwillee