chore: refactor to address sonarlint issue

medic · Nov 14, 2024 · dc1cfd5 · dc1cfd5
1 parent 82231b1
commit dc1cfd5
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 13 deletions.
diff --git a/models/users/feedback.sql b/models/users/feedback.sql
@@ -1,13 +1,14 @@
+{% set COLUMNS = 'columns' %}
 {{
   config(
     materialized = 'incremental',
     unique_key='uuid',
     on_schema_change='append_new_columns',
     indexes=[
-      {'columns': ['uuid'], 'type': 'hash'},
-      {'columns': ['saved_timestamp']},
-      {'columns': ['period_start']},
-      {'columns': ['user_name']},
+      {COLUMNS: ['uuid'], 'type': 'hash'},
+      {COLUMNS: ['saved_timestamp']},
+      {COLUMNS: ['period_start']},
+      {COLUMNS: ['user_name']},
     ]
   )
 }}

diff --git a/models/users/telemetry.sql b/models/users/telemetry.sql
@@ -1,14 +1,15 @@
+{% set COLUMNS = 'columns' %}
 {{
   config(
     materialized = 'incremental',
     unique_key='uuid',
     on_schema_change='append_new_columns',
     indexes=[
-      {'columns': ['uuid'], 'type': 'hash'},
-      {'columns': ['saved_timestamp']},
-      {'columns': ['period_start']},
-      {'columns': ['user_name']},
-      {'columns': ['app_version']},
+      {COLUMNS: ['uuid'], 'type': 'hash'},
+      {COLUMNS: ['saved_timestamp']},
+      {COLUMNS: ['period_start']},
+      {COLUMNS: ['user_name']},
+      {COLUMNS: ['app_version']},
     ]
   )
 }}

diff --git a/models/users/telemetry_devices.sql b/models/users/telemetry_devices.sql
@@ -1,13 +1,14 @@
+{% set COLUMNS = 'columns' %}
 {{
   config(
     materialized = 'incremental',
     unique_key='uuid',
     on_schema_change='append_new_columns',
     indexes=[
-      {'columns': ['uuid'], 'type': 'hash'},
-      {'columns': ['saved_timestamp']},
-      {'columns': ['period_start']},
-      {'columns': ['android_version']},
+      {COLUMNS: ['uuid'], 'type': 'hash'},
+      {COLUMNS: ['saved_timestamp']},
+      {COLUMNS: ['period_start']},
+      {COLUMNS: ['android_version']},
     ]
   )
 }}