-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove motion remap #705
base: master
Are you sure you want to change the base?
Remove motion remap #705
Conversation
It works well for me in accessing overridden keys in motion state. Are we hoping for this to be able to do self insertions or will we require to explicitly bind them in the future? Right now the meow-keypad-leader-transparent for normal state doesn't do what I would have expected, i assume we would need to have some fallback: look up the key in current-local-map, if it is not bound there, look it up in the global map instead. I think we would still need to set last-input-event and last-command-event. |
Yep, I expect this to support |
With these changes, would there be a built-in way to support triggering the original key binding with a separate key in the Motion state? If not, would you be willing to add a helper command that runs the binding outside of the Meow maps, such as using the code added to Then, such a helper command could be used directly, maybe in I think having such a command, that would need to be bound by the user, would cover the old behavior without interfering with this new proposed behavior. |
I think we can add a command to achieve this. |
I haven't really looked at how the remapping of keys works internally but I have a couple of keypad binds like |
I've done some quick testing and the transparency through to global-map works now, as well as the last-input and command -event seem to set properly. Some things that I noticed is that when doing insert through the transparency functionality it doesn't input the undo-boundary as I would expect, but it does if I instead bind self-insert-command explicitly in the keypad. Also it seems like meow-keypad-execute-on-beacons doesn't work for transparency. Maybe instead of calling the command directly from the |
This is an attempt to remove the rebinding in motion state. An idea of transparent motion is introduced to achieve the same effect.
It adds a variable
meow-keypad-leader-transparent
which acceptst
,motion
,normal
andnil
. The default value ismotion
which means only in motion mode, the leader is transparent. Therefore, we no longer need the rebind toH-*
, any free key on leader can be used to execute the original command.NB: This will be a breaking change.