New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Avoid model generator workflow to push formatting changes in SVGs #653

Open

riyaa14 wants to merge 2 commits into meshery:master from riyaa14:fix-model-generation-workflow

riyaa14 commented Jan 23, 2025

Description

This PR fixes #652

Notes for Reviewers

update.go and generate.go in registry, both use Parser function implemented in csv.go
fixing the parsing of svg columns here should fix the unnecessary formatting changes that were being generated
The formatting of svg columns is kept uniform by removing all new-line characters (\n)

Signed commits

Yes, I signed my commits.


          avoid model generate workflow to push formatting changes in SVGs

f4d4b0b

Signed-off-by: Riya Garg <[email protected]>

welcome bot commented Jan 23, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

riyaa14 marked this pull request as ready for review

January 23, 2025 12:20


          fix formatting for column 'svgcomplete'

31c6d21

Signed-off-by: Riya Garg <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet