-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vLLM raw completions API #823
base: main
Are you sure you want to change the base?
Conversation
6823a60
to
09fc380
Compare
@@ -118,6 +118,7 @@ async def test_completion(self, inference_model, inference_stack): | |||
"remote::fireworks", | |||
"remote::nvidia", | |||
"remote::cerebras", | |||
"remote::vllm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you just remove this block now entirely? whichever provider fails the test better just show up as a Failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What does this PR do?
Adds raw completions API to vLLM
Test Plan
Setup
Integration
Manual
# Install pip install --no-cache --index-url https://pypi.org/simple/ --extra-index-url https://test.pypi.org/simple/ llama-stack==0.1.0rc7
Apply this diff
Test 1:
Test 2
Before submitting
Pull Request section?