add pytest option to generate a functional report for distribution #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sixianyi0721
force-pushed
the
client-sdk-test
branch
2 times, most recently
from
d8ec744 to
0246333
Compare
sixianyi0721
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv and
vladimirivic
as code owners
hardikjshah
approved these changes
Jan 22, 2025
| rows = [] | ||
| for model in all_registered_models(): | ||
| if ( | ||
| "Instruct" not in model.core_model_id.value |
There was a problem hiding this comment.
model.is_instruct_model() might be better to use for instruct models.
and for safety models, might be better to check model family and if its ModelFamily.safety
| INFERENCE_API_CAPA_TEST_MAP = { | ||
| "chat_completion": { | ||
| "streaming": [ | ||
| "test_text_chat_completion_streaming", |
There was a problem hiding this comment.
this implies that we need to manually add tests to this list , everytime we add new capabilities. Not ideal but something we can look into as a follow up .
There was a problem hiding this comment.
@hardikjshah
Since we want to find out the corresponding tests given an api and the capability, the other approaches are
- parse test function name
- add markers (ex. pytest.marker.structured_output) to each test
I think both would be less cleaner and therefore i prefer the current approach. Lemme know if you have other suggestions! :)
sixianyi0721
force-pushed
the
client-sdk-test
branch
2 times, most recently
from
c9fc1c0 to
2ace8d2
Compare
sixianyi0721
force-pushed
the
client-sdk-test
branch
from
2ace8d2 to
e9f49a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add pytest option (
--report) to support generating a functional report for llama stack distributionTest Plan
See a report file was generated under
./llama_stack/templates/fireworks/report.mdSources
Please link relevant resources if necessary.
Before submitting
Pull Request section?