Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[memory refactor][6/n] Update naming and routes #839

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[memory refactor][6/n] Update naming and routes #839

merged 1 commit into from
Jan 22, 2025
+240 −251

Conversation

ashwinb
Copy link
Contributor

@ashwinb ashwinb commented Jan 22, 2025

Making a few small naming changes as per feedback:

  • RAGToolRuntime methods are called insert and query to keep them more general
  • The tool names are changed to non-namespaced forms insert_into_memory and query_from_memory
  • The REST endpoints are more REST-ful

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 22, 2025
@ashwinb ashwinb force-pushed the rename_query_context branch from c04a9c4 to c295a2b Compare January 22, 2025 17:33
@ashwinb ashwinb force-pushed the rename_query_context branch 3 times, most recently from 248a412 to b9f71a6 Compare January 22, 2025 17:59
@ashwinb ashwinb force-pushed the migrate_all_vector_io branch from 1de1587 to 33ea913 Compare January 22, 2025 18:17
Base automatically changed from migrate_all_vector_io to main January 22, 2025 18:18
@ashwinb ashwinb force-pushed the rename_query_context branch from b9f71a6 to 3f89c73 Compare January 22, 2025 18:24
@ashwinb ashwinb merged commit a63a43c into main Jan 22, 2025
2 checks passed
@ashwinb ashwinb deleted the rename_query_context branch January 22, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikjshah hardikjshah hardikjshah approved these changes

@raghotham raghotham raghotham approved these changes

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashwinb @raghotham @hardikjshah @facebook-github-bot