FS-963 Fix duplicate message publish on success (#169)

* Fix an issue where duplicate "success" messages for firmware inventory are showing up in Slack.
* Fix lint issue G601

internal/store/serverservice/components.go

@@ -1167,15 +1167,23 @@ func (r *Store) enrichFirmwareData(deviceVendor, componentVendor string, vattr *
 	// Check in the cache if we have a match by vendor + version
 	for _, fw := range r.firmwares[componentVendor] {
 		if strings.EqualFold(fw.Version, vattr.Firmware.Installed) {
+			fwUUID := fw.UUID
+
 			vattr.Vendor = fw.Vendor
-			vattr.UUID = &fw.UUID
+			vattr.UUID = &fwUUID
+
+			return
 		}
 	}
 
 	for _, fw := range r.firmwares[deviceVendor] {
 		if strings.EqualFold(fw.Version, vattr.Firmware.Installed) {
+			fwUUID := fw.UUID
+
 			vattr.Vendor = fw.Vendor
-			vattr.UUID = &fw.UUID
+			vattr.UUID = &fwUUID
+
+			return
 		}
 	}
 }

internal/worker/worker.go

@@ -317,8 +317,6 @@ func (w *Worker) doWork(ctx context.Context, condition *rctypes.Condition, e eve
 		task.SetState(rctypes.Succeeded)
 		task.Status = "collection completed successfully"
 
-		publisher.Publish(ctx, task)
-
 		w.eventAckComplete(e)
 
 		metrics.RegisterConditionMetrics(startTS, string(rctypes.Succeeded))
@@ -332,8 +330,6 @@ func (w *Worker) doWork(ctx context.Context, condition *rctypes.Condition, e eve
 			nil,
 		)
 
-		publisher.Publish(ctx, task)
-
 		w.logger.WithFields(logrus.Fields{
 			"serverID":    task.Parameters.AssetID.String(),
 			"conditionID": task.ID,
@@ -349,8 +345,6 @@ func (w *Worker) doWork(ctx context.Context, condition *rctypes.Condition, e eve
 
 		w.eventNak(e) // have the message bus re-deliver the message
 
-		publisher.Publish(ctx, task)
-
 		metrics.RegisterEventCounter(true, "nack")
 		metrics.RegisterConditionMetrics(startTS, string(rctypes.Failed))
 		metrics.RegisterSpanEvent(
@@ -377,8 +371,6 @@ func (w *Worker) doWork(ctx context.Context, condition *rctypes.Condition, e eve
 
 		w.eventAckComplete(e)
 
-		publisher.Publish(ctx, task)
-
 		metrics.RegisterConditionMetrics(startTS, string(rctypes.Failed))
 		metrics.RegisterEventCounter(true, "ack")
 		metrics.RegisterSpanEvent(
@@ -398,6 +390,9 @@ func (w *Worker) doWork(ctx context.Context, condition *rctypes.Condition, e eve
 			"status":      task.Status,
 		}).Info("task for device failed")
 	}
+
+	// publish result
+	publisher.Publish(ctx, task)
 }
 
 // runTaskWithMonitor runs the task method based on the parameters, while ack'ing its progress to the NATS JS.