-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency psr/link to v2 #58
Conversation
99c2ba0
to
b3fcfbc
Compare
Looks like this is going to require dropping PHP 7.4 support to fix as the signature: public function withLink(LinkInterface $link): self needs to become public function withLink(LinkInterface $link): static and the static return return type doesn't exist until PHP 8.0. Testing out some of these fixes, it seems to support |
Since our symbols are not We have 2 alternatives:
A lot of added |
b3fcfbc
to
6465216
Compare
I think introducing new majors in packages like this is fine. There are only three dependents listed on packagist: |
@boesing you mean "inheritance unlikely"? I'd still release a major for correctness then, but skipping v1 + v2 compat, and going straight for v2... |
6465216
to
dc920ba
Compare
@Ocramius But this component here is used in 0 of our own components and only a hand full of other components on packagist use this component at all. |
6e73cde
to
4134a9f
Compare
d0c77f0
to
37bb6a5
Compare
OK, so to sum up, when I get the time again, I will update #59 to:
We would not be able to support both 1 and 2 from what I gathered when I was last looking at this due to the signature changes (happy to stand corrected if someone else figures out a way though). At least not without some intervention as to which class is loaded based on the PHP version or installed |
Sounds reasonable: go for it whenever you want 👍 |
5ef585e
to
20451df
Compare
85c821f
to
5dfaf27
Compare
5dfaf27
to
7e3d7f7
Compare
| datasource | package | from | to | | ---------- | -------- | ----- | ----- | | packagist | psr/link | 1.0.0 | 2.0.1 | Signed-off-by: Renovate Bot <[email protected]>
7e3d7f7
to
988ca43
Compare
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
^1.0
->^1.0 || ^2.0
Release Notes
php-fig/link
v2.0.1
Compare Source
Changed
$value
parameter ofEvolvableLinkInterface::withAttribute()
was widened to comply with the original specification.v2.0.0
Compare Source
Changed
v1.1.1
Compare Source
v1.1.0
Compare Source
Changed
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
Read more information about the use of Renovate Bot within Laminas.