Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support node name for non-captioned #145

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat: support node name for non-captioned #145

merged 1 commit into from
Sep 12, 2024

Conversation

christiangrett
Copy link
Contributor

@christiangrett christiangrett commented Jul 30, 2024 •
edited
Loading

The name attribute adds an ID to the figure element of the mermaid diagram:

example:

.. mermaid::
   :name: my_mermaid_diagram
   :caption: An example of a sequence diagram

causes

<figure class="align-default" id="my_mermaid_diagram">...</figure>

@christiangrett christiangrett changed the title feat: support node name for non-captioned feat: support node name for non-captioned Jul 30, 2024
@christiangrett
Copy link
Contributor Author

related to: https://github.com/mgaitan/sphinxcontrib-mermaid/pull/88/files

@timkpaine timkpaine mentioned this pull request Sep 12, 2024
Closed
@timkpaine timkpaine marked this pull request as ready for review September 12, 2024 15:18
@timkpaine timkpaine merged commit 30e6a13 into mgaitan:master Sep 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christiangrett @timkpaine