Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: missing packages to DESCRIPTION #630

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

artur-sannikov
Copy link
Contributor

Packages SuperLearner, cowplot, and scuttles were missing from the DESCRIPTION file.

@TuomasBorman
Copy link
Contributor

Are SuperLearner and cowplot needed? They are not directly used in the book, they are just dependencies of IntegratedLearner. The package does not use correctly the dependencies and hopefully it will be fixed soon

@artur-sannikov
Copy link
Contributor Author

When I was building the book, it said that these dependencies are missing.

@antagomir
Copy link
Member

Shall we merge this for now, if this is a practical problem? For me OK to merge.

Or do we convert this into an issue to be checked later and close this PR for the time being?

@TuomasBorman
Copy link
Contributor

It seems that the book is building correctly in GHA

@TuomasBorman
Copy link
Contributor

What command did you use to build the book. These packages should already come with other packages. I am fine with this PR, but managing this many packages is challenging and we might have troubles in Bioc submission

@artur-sannikov
Copy link
Contributor Author

It's complaining about these packages at the BiocBook::preview(BiocBook::BiocBook('.')) stage.

> BiocBook::preview(BiocBook::BiocBook('.'))
✖ Some dependencies found in book pages are not listed in DESCRIPTION: 
  • SuperLearner
  • cowplot
  • scuttle
ℹ Consider adding these dependencies to DESCRIPTION

If it builds fine, however, we can close this PR.

@TuomasBorman
Copy link
Contributor

Alright, I think it is fine adding these. I am not sure when IntegratedLearner will be fixed anyways. I can check these dependencies later that all are really needed. Thanks!

@TuomasBorman TuomasBorman merged commit 25edf99 into microbiome:devel Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants