Skip to content

Commit

Permalink
Disable local auth in EventGrid
Browse files Browse the repository at this point in the history
  • Loading branch information
tamirkamara committed Jan 6, 2025
1 parent 5f27bae commit 9c0ee44
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/build_validation_develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ jobs:
terraform_workspace_services:
- templates/workspace_services/**/terraform/**/*.tf
- uses: hashicorp/setup-terraform@v3
if: ${{ steps.filter.outputs.terraform == 'true' }}
with:
terraform_version: "1.9.8"

- name: Terraform format check
if: ${{ steps.filter.outputs.terraform == 'true' }}
run: terraform fmt -check -recursive
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ concurrency:
jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
permissions:
actions: read
contents: read
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ ENHANCEMENTS:
* Upgrade Python version from 3.8 to 3.12 ([#3949](https://github.com/microsoft/AzureTRE/issues/3949))Upgrade Python version from 3.8 to 3.12 (#3949)
* Disable storage account key usage ([[#4227](https://github.com/microsoft/AzureTRE/issues/4227)])
* Update Guacamole dependencies ([[#4232](https://github.com/microsoft/AzureTRE/issues/4232)])
* Disable local authentication in EventGrid ([[#4254](https://github.com/microsoft/AzureTRE/issues/4254)])

BUG FIXES:
* Update KeyVault references in API to use the version so Terraform cascades the update ([#4112](https://github.com/microsoft/AzureTRE/pull/4112))
Expand Down
5 changes: 5 additions & 0 deletions core/terraform/airlock/eventgrid_topics.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ resource "azurerm_eventgrid_topic" "step_result" {
location = var.location
resource_group_name = var.resource_group_name
public_network_access_enabled = var.enable_local_debugging
local_auth_enabled = false

identity {
type = "SystemAssigned"
Expand Down Expand Up @@ -65,6 +66,7 @@ resource "azurerm_eventgrid_topic" "status_changed" {
location = var.location
resource_group_name = var.resource_group_name
public_network_access_enabled = var.enable_local_debugging
local_auth_enabled = false

identity {
type = "SystemAssigned"
Expand Down Expand Up @@ -118,6 +120,7 @@ resource "azurerm_eventgrid_topic" "data_deletion" {
location = var.location
resource_group_name = var.resource_group_name
public_network_access_enabled = var.enable_local_debugging
local_auth_enabled = false

identity {
type = "SystemAssigned"
Expand Down Expand Up @@ -168,6 +171,7 @@ resource "azurerm_eventgrid_topic" "scan_result" {
resource_group_name = var.resource_group_name
# This is mandatory for the scan result to be published since private networks are not supported yet
public_network_access_enabled = true
local_auth_enabled = false

identity {
type = "SystemAssigned"
Expand Down Expand Up @@ -328,6 +332,7 @@ resource "azurerm_eventgrid_topic" "airlock_notification" {
location = var.location
resource_group_name = var.resource_group_name
public_network_access_enabled = var.enable_local_debugging
local_auth_enabled = false

identity {
type = "SystemAssigned"
Expand Down
2 changes: 1 addition & 1 deletion core/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.11.15"
__version__ = "0.11.16"

0 comments on commit 9c0ee44

Please sign in to comment.