Provide Airlock Import Review Workspace with its own DNS zone #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/6667034468 (with refid (in response to this comment from @marrobi) |
|
Successfully tested new workspace deployment. Troubleshooting workspace upgrade. |
Verified upgrade works:
|
|
/test-force-approve Passed: https://github.com/microsoft/AzureTRE/actions/runs/6667034468 |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 9255f2d) (in response to this comment from @marrobi) |
anatbal
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3767
To resolve the Airlock import issue described in (#3767) the new airlock import review tempalte in this PR will need registering using
make workspace_bundle BUNDLE=airlock-import-reviewand any existing airlock import review workspaces will need upgrading. After upgrade runmake deploy-coreto reinstate and deleted DNS records.How is this addressed
vnet_idoutput of the network module. Temp fix can be removed after the next release.I have tested the end to end import process.