Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Guacamole dependencies #4232

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

Update to latest dependencies to resolve some potential vulnerabilities as opened by #4231, #4182

Copy link

github-actions bot commented Dec 30, 2024

Unit Test Results

15 tests   15 ✅  1s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 88261f3.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@tamirkamara tamirkamara enabled auto-merge (squash) December 30, 2024 13:06
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12546970162 (with refid e433c91c)

(in response to this comment from @tamirkamara)

@jonnyry
Copy link
Collaborator

jonnyry commented Dec 30, 2024

@tamirkamara any chance in bumping Tomcat from 9.0.97 to 9.0.98 as well?

ENV CATALINA_BASE=/usr/share/tomcat9/
RUN TOMCAT_ARCHIVE="tomcat.tar.gz" && \
TOMCAT_VER="9.0.97" && \

Few CVEs in 9.0.97 that are fixed in 9.0.98:

https://tomcat.apache.org/security-9.html#Fixed_in_Apache_Tomcat_9.0.98

@tamirkamara
Copy link
Collaborator Author

@jonnyry already done :-)

@jonnyry
Copy link
Collaborator

jonnyry commented Dec 30, 2024

@jonnyry already done :-)

Ah missed that, excellent!

@jonnyry jonnyry self-requested a review December 30, 2024 13:28
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12546970162 (with refid e433c91c)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve
failed latest run is unrelated to guacamole

Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 88261f3)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit c199703 into main Dec 30, 2024
12 checks passed
@tamirkamara tamirkamara deleted the tamirkamara/fix-guacamole-deps branch December 30, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants